Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-blackbox-exporter: 0.15.1 -> 0.16.0, disable tests #73239

Merged
merged 1 commit into from Nov 12, 2019
Merged

prometheus-blackbox-exporter: 0.15.1 -> 0.16.0, disable tests #73239

merged 1 commit into from Nov 12, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

New release: https://github.com/prometheus/blackbox_exporter/releases/tag/v0.16.0

Things done

Disabled tests again, after enabling them recently, because networking would be required for a dns lookup.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.blackbox

@ofborg ofborg bot requested review from ehmry, fpletz and globin November 11, 2019 19:13
@Ma27 Ma27 merged commit a93fd10 into NixOS:master Nov 12, 2019
@WilliButz WilliButz deleted the update-blackbox-exporter branch November 14, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27