Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.FindLib: init at 1.04 #73202

Merged
merged 1 commit into from Nov 12, 2019
Merged

perlPackages.FindLib: init at 1.04 #73202

merged 1 commit into from Nov 12, 2019

Conversation

tekeri
Copy link
Contributor

@tekeri tekeri commented Nov 11, 2019

Motivation for this change

Add a missing perl package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @stigtsp @puckipedia @c0bw3b @FRidh

@tekeri tekeri changed the title perlPackages-Find-Lib: init at 1.04 perlPackages.Find-Lib: init at 1.04 Nov 11, 2019
@stigtsp
Copy link
Member

stigtsp commented Nov 11, 2019

nix-review pr 73202 returned:

2 package were build:
perl528Packages.FindLib perl530Packages.FindLib

@tekeri
Copy link
Contributor Author

tekeri commented Nov 11, 2019

Thanks @stigtsp, I'm learning about nix-review.

@stigtsp
Copy link
Member

stigtsp commented Nov 11, 2019

Can you amend the previous commit so it's one commit?

@tekeri
Copy link
Contributor Author

tekeri commented Nov 11, 2019

It should be clean now.

@tekeri tekeri changed the title perlPackages.Find-Lib: init at 1.04 perlPackages.FindLib: init at 1.04 Nov 11, 2019
stigtsp
stigtsp approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2019

@GrahamcOfBorg build perl528Packages.FindLib perl530Packages.FindLib

@c0bw3b c0bw3b merged commit 6b0843d into NixOS:master Nov 12, 2019
@tekeri
Copy link
Contributor Author

tekeri commented Nov 12, 2019

Thanks @stigtsp, @c0bw3b !

@tekeri tekeri deleted the add-perl-findlib branch November 12, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tekeri @stigtsp @c0bw3b