Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow-cpp: fix on i686-linux #73203

Merged
merged 1 commit into from Nov 11, 2019
Merged

arrow-cpp: fix on i686-linux #73203

merged 1 commit into from Nov 11, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 11, 2019

Motivation for this change

Workaround #36947 for arrow-cpp

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tobim

@veprbl
Copy link
Member Author

veprbl commented Nov 11, 2019

@GrahamcOfBorg build pkgsi686Linux.arrow-cpp

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 11, 2019
@veprbl veprbl merged commit 418f550 into NixOS:master Nov 11, 2019
@veprbl
Copy link
Member Author

veprbl commented Nov 11, 2019

backported in 100ee02

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 11, 2019
@veprbl veprbl deleted the pr/arrow-cpp_i686 branch December 1, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant