Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/realm/jazzy/releases/tag/v0.12.0
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Regarding the sandbox, I had to compile
jazzy.gems.ffi
andjazzy.gems.sassc
without the sandbox due to #73310 and NixOS/nix#3223, but that's a pre-existing issue (and only affects macOS 10.15). However thejazzy
gem itself (and all other dependencies) compile under the sandbox (with the standard set ofextra-sandbox-paths
I use for Darwin due to Nix's darwin impurities).