Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/slurm: fix test and X11 options #73179

Merged
merged 3 commits into from Nov 12, 2019
Merged

nixos/slurm: fix test and X11 options #73179

merged 3 commits into from Nov 12, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Nov 10, 2019 •
edited

Motivation for this change

This PR fixes two bugs:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@markuskowa
nixos/slurm: fix X11 with spank module
8219a3b 
* Fix path in module for slurm to find plugstack.conf
* Fix configure flags so that slurm can be compiled
  without internal X11 support (required for spank-x11).
@markuskowa
nixos/slurm: add option for external slurmdbd.conf
472e165 
Slurmdbd requires a password database which is stored in slurmdbd.conf.
A seperate config file avoids that the password ends up in the nix store.

Slurmdbd does 19.5 does not support MySQL socket conections.
Adapated the slurm test to provide username and password.
@markuskowa
Copy link
Member Author

markuskowa commented Nov 10, 2019 •
edited

@GrahamcOfBorg test slurm

@tfc tfc mentioned this pull request Nov 11, 2019
Closed
veprbl
veprbl approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a slurm or NixOS user, but LGTM.

@markuskowa markuskowa merged commit 6928cb2 into NixOS:master Nov 12, 2019
@markuskowa markuskowa deleted the fix-slurm branch November 12, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @veprbl