New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: nixos/ceph: port tests to python #73190
Conversation
f07a2c1
to
6f3e1b2
Compare
6f3e1b2
to
73fdde6
Compare
73fdde6
to
1d6a9f9
Compare
Turns out, it's wasting cpu cycles in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, it doesn't change any of the test cases, merely just changes the syntax of calling.
The only comment I have is that in the lines where there is more than one command in a row, and thus a comma-separated list is given to succeed() for example, there seems to be some extra whitespace that gets added. Is that intentionally or just your editor interprenting tabs as 4 spaces or something? I don't really care if its 2, 4, 8 or more spaces, the indentation is coherent and that is the important part. Just wanted to highlight it to see if it was an intended or unintended change.
4 spaces is what the python community does for code, so I am fine with that. |
Yeah, I'm completely fine with it too, just wanted to point it out, in case it wasn't intentional :) |
1d6a9f9
to
dd96dae
Compare
dd96dae
to
6815017
Compare
Got the test to work - they uncovered two issues in the python test driver, which didn't behave exactly like the perl one (passing of environment to the script executing qemu, handling in the Thanks to @tfc, these are fixed now. Rebased on latest master and cherry-picked them in. PTAL. |
@GrahamcOfBorg test ceph-single-node ceph-multi-node |
Motivation for this change
#72828
Contains commits from #72603 and #73189 and should be rebased on top of master once these are merged.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @tfc @worldofpeace