Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: init at 1.0.0 #73188

Merged
merged 2 commits into from Nov 17, 2019
Merged

spike: init at 1.0.0 #73188

merged 2 commits into from Nov 17, 2019

Conversation

blitz
Copy link
Contributor

@blitz blitz commented Nov 10, 2019

Motivation for this change

Spike is the RISC-V ISA simulator of the RISC-V project. It aids in developing RISC-V software.

Open Questions

I've pulled in cross compiled versions of hello and the RISC-V proxy kernel in the spike integration test. As far as I can see, this is the first integration test that relies on cross-compilation and I'm not sure that this is ok.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @shlevy

Spike is the RISC-V ISA simulator from the RISC-V project.
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review and by building the provided test

@Lassulus Lassulus merged commit ce52d6b into NixOS:master Nov 17, 2019
@blitz blitz deleted the spike branch November 22, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants