Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texstudio: fix qt wrapping and explicitly receive qt attributes #73298

Merged
merged 2 commits into from Nov 13, 2019
Merged

texstudio: fix qt wrapping and explicitly receive qt attributes #73298

merged 2 commits into from Nov 13, 2019

Conversation

gameboo
Copy link
Contributor

@gameboo gameboo commented Nov 12, 2019

mkDerivation fixes the qt wrapping issue

Motivation for this change
Things done

@KoviRobi checked this on NixOS 19.09

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Chaddai

@gameboo
texstudio: fix qt wrapping explicitly receiving qt attributes
3b7b750 
mkDerivation fixes the qt wrapping issue
@KoviRobi
Copy link
Contributor

On my NixOS 19.09, I have nix.useSandbox set to true

@ofborg ofborg bot requested a review from Chaddai November 12, 2019 16:38
@veprbl veprbl merged commit 4f9fae2 into NixOS:master Nov 13, 2019
bjornfor pushed a commit that referenced this pull request Jan 5, 2020
@gameboo @bjornfor
texstudio: fix qt wrapping and explicitly receive qt attributes (#73298)
f99bc99 
(cherry picked from commit 4f9fae2)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 15, 2020
@gameboo @dtzWill
texstudio: fix qt wrapping and explicitly receive qt attributes (NixO…
8d2bec6 
…S#73298)

(cherry picked from commit 4f9fae2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@Chaddai Chaddai Awaiting requested review from Chaddai

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gameboo @KoviRobi @veprbl @Janik-Haag