Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canon-cups-ufr2: 2.90 -> 3.70 #73307

Merged
merged 3 commits into from Nov 20, 2019
Merged

Conversation

kylesferrazza
Copy link
Member

Motivation for this change

My Canon MF240 was not supported by the current version of the canon-cups-ufr2 driver.
Closes #55447

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Note

I based this update on changes to the rpm .spec file bundled with the source. I'm not super familiar with autotools so this update may not be complete.
The driver works with my Canon MF240, but needs testing with other printers before merging.

@cptMikky if you still have the canon printer for testing this, that would be great

Also 5.00 is now available, but this is a step in the right direction

@kylesferrazza kylesferrazza changed the title Update canon canon-cups-ufr2: 2.90 -> 3.70 Nov 12, 2019
@Lassulus
Copy link
Member

since you already touched it, maybe you want to add yourself as a maintainer? :)

@Lassulus Lassulus merged commit a548423 into NixOS:master Nov 20, 2019
@kylesferrazza kylesferrazza deleted the update-canon branch November 21, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update canon-cups-ufr2
2 participants