Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages."@angular/cli": disable analytics #73225

Merged
merged 2 commits into from Feb 10, 2020
Merged

nodePackages."@angular/cli": disable analytics #73225

merged 2 commits into from Feb 10, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Nov 11, 2019 •
edited

Motivation for this change

@angular/cli fails to build due to the prompt for NG_CLI_ANALYTICS
Here is the relevant portion of analytics-prompt.js.

Set NG_ANALYTICS to false to skip this prompt and allow the build to continue

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evanjs
Copy link
Member Author

evanjs commented Nov 17, 2019

So this is sort of odd...
I just came across this commit, which said it fixed this sort of issue before.

I wonder why it suddenly stopped working; maybe addressing that issue might be a better idea?

evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Dec 7, 2019
@evanjs
@angular/cli - add override for NG_CLI_ANALYTICS
1abb493 
- for more information, see NixOS/nixpkgs#73225
@evanjs evanjs mentioned this pull request Feb 7, 2020
Merged
10 tasks
evanjs and others added 2 commits February 9, 2020 22:54
@evanjs
nodePackages: update set
f298263
@evanjs
nodePackages_10_x."@angular/cli": disable analytics
a68edf4 
@angular/cli fails to build due to the prompt for NG_CLI_ANALYTICS

Set NG_CLI_ANALYTICS to false to skip this prompt and allow the build to
continue
@evanjs evanjs force-pushed the disable-angular_cli-analytics branch from 436d20f to a68edf4 Compare February 10, 2020 03:54
@Mic92 Mic92 merged commit 21e1500 into NixOS:master Feb 10, 2020
@evanjs evanjs deleted the disable-angular_cli-analytics branch February 11, 2020 15:33
evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Feb 20, 2020
@evanjs
modules/development: remove @angular/cli workaround
d24cc53 
This patch has been merged upstream in NixOS/nixpkgs#73225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanjs @Mic92