Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkl: add scalapack libraries to output #73227

Merged
merged 1 commit into from Nov 18, 2019
Merged

mkl: add scalapack libraries to output #73227

merged 1 commit into from Nov 18, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

Add the scalapack extensions to the output.

Things done

Tested compilation with an external program (bagel quantum chemistry). Seems to work fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bhipple

@ofborg ofborg bot requested a review from bhipple November 11, 2019 15:26
smaret
smaret reviewed Nov 15, 2019
View reviewed changes
Copy link
Member

@smaret smaret left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Darwin we unpack and install all the libraries from the MKL. Perhaps we should do the same for NixOS/Linux?

@markuskowa
Copy link
Member Author

@smaret Not sure it would make sense to unpack all RPMs. There is a lot of stuff that is distributed of a bunch directories that may not be required. @bhipple may be able to give more insight here.

bhipple
bhipple approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a whitelist of RPMs to include -- as we're currently doing -- is preferable to including everything. It's relatively easy to add more if people need it, and there are many packages unlikely to be used.

I might :sort the list though.

@ofborg ofborg bot requested a review from bhipple November 18, 2019 08:14
@markuskowa markuskowa merged commit 7d728fa into NixOS:master Nov 18, 2019
@markuskowa markuskowa deleted the fix-mkl branch November 18, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaret smaret smaret left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

@costrouc costrouc Awaiting requested review from costrouc

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @smaret @bhipple