Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/development/libraries: add missing descriptions and homepages #73312

Merged
merged 1 commit into from Nov 17, 2019

Conversation

cko
Copy link
Member

@cko cko commented Nov 12, 2019

Motivation for this change

Many packages below pkgs/development/libraries lack a description and sometimes also a homepage in their metadata. This PR adds some.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2019

From our guidelines, short descriptions shouldn't end with a dot.

@cko
Copy link
Member Author

cko commented Nov 16, 2019

From our guidelines, short descriptions shouldn't end with a dot.

oh, damn. I'm mixing this up every single time. Fixed now.

@c0bw3b c0bw3b merged commit 96476e6 into NixOS:master Nov 17, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants