Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmad, mpg321: fix four CVE #73234

Closed
wants to merge 2 commits into from
Closed

libmad, mpg321: fix four CVE #73234

wants to merge 2 commits into from

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 11, 2019

Motivation for this change

Close #57154
Close #70105

CVE-2018-7263 is associated to libmad but it's actually an issue in mpg321

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @rycee

@c0bw3b
libmad: fix three CVE from 2017
8f8917f 
* add patch for CVE-2017-8372 and CVE-2017-8373
* add patch for CVE-2017-8374
* add patch for x86_64 platforms
* fetch existing patches from remote sources
@c0bw3b
mpg321: fix CVE-2018-7263
60c8875 
Close NixOS#57154
Close NixOS#70105
@c0bw3b c0bw3b changed the title Sec/mp3cve libmad, mpg321: fix four CVE Nov 11, 2019
@ofborg ofborg bot requested review from rycee and lovek323 November 11, 2019 17:04
@rycee
Copy link
Member

rycee commented Nov 11, 2019

Thanks! Looks good to me. Rebased to master in 1289606.

@rycee rycee closed this Nov 11, 2019
c0bw3b added a commit that referenced this pull request Nov 21, 2019
@c0bw3b
libmad: fix three CVE from 2017
b51f069 
* add patch for CVE-2017-8372 and CVE-2017-8373
* add patch for CVE-2017-8374
* add patch for x86_64 platforms
* fetch existing patches from remote sources

Backport of #73234
(cherry picked from commit 92edb06)
c0bw3b added a commit that referenced this pull request Nov 21, 2019
@c0bw3b
mpg321: fix CVE-2018-7263
c5c326e 
Close #57154
Close #70105

Backport of #73234
(cherry picked from commit 1289606)
@c0bw3b c0bw3b deleted the sec/mp3cve branch November 21, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @rycee