Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] vimPlugins.vimelette: init at 2019-05-02 #73273

Closed

Conversation

gotcha
Copy link
Contributor

@gotcha gotcha commented Nov 12, 2019

Added vim plugin vimelette

@jonringer
Copy link
Contributor

I think you meant to do this against master.... not nixpkgs-19.09-darwin

@gotcha
Copy link
Contributor Author

gotcha commented Nov 13, 2019

@jonringer I already did it against master and it got merged.

Then I wondered how to get from master to nixpkgs-19.09-darwin (See https://discourse.nixos.org/t/nixpkgs-flow-from-master-to-channel/4727).
I understood (maybe wrongly) that I also need a PR in nixpkgs-19.09-darwin

@jonringer
Copy link
Contributor

do you mind doing a

nix-channel --list
sudo nix-channel --list

and posting the output?

@jonringer
Copy link
Contributor

cc @NixOS/darwin-maintainers @NixOS/channel-updaters what's the policy on the darwin variant channels?

@LnL7
Copy link
Member

LnL7 commented Nov 13, 2019

I'm not sure what the nixpkgs-19.09-darwin branch is but it has nothing to do with the channel.

@LnL7
Copy link
Member

LnL7 commented Nov 13, 2019

If you want to backport changes to a release please use git cherry-pick -x to include a reference to the original commit and target the release-19.09 branch.

@gotcha
Copy link
Contributor Author

gotcha commented Nov 14, 2019

Well, it seems I first need to better understand how nixpkgs branches get turned into channels.
@LnL7 @jonringer Any pointers ?

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2019

@gotcha To be honest, I'm not sure I can point to anything specific. I definitively agree this should be described somewhere. Apparently these channel branches are a recent change for technical reasons, but the fact that they exist makes this even more important now to avoid confusion.

@jonringer
Copy link
Contributor

agreed, and I'm not sure who's driving the darwin channels, but I would like to know their intent with using the darwin variant channels. Only benefit i could see is that it would clear out a lot of non-darwin noise when looking through hydra jobsets, but I think that should be a feature on hydra to sort by targeted architecture

@timokau timokau changed the title vimPlugins.vimelette: init at 2019-05-02 [19.09] vimPlugins.vimelette: init at 2019-05-02 Nov 16, 2019
@timokau
Copy link
Member

timokau commented Nov 16, 2019

Either way, the vim-plugins update should not go to the stable channel. It might break things. I'm fine with backporting new packages (i.e. just the vimlette init, not the update), but I'm not sure what the general policy there is.

@jonringer
Copy link
Contributor

@gotcha IIRC, you already landed a PR in master, do you mind running:

nix-channel --list
sudo nix-channel --list

this PR might not even be necessary

@gotcha
Copy link
Contributor Author

gotcha commented Nov 17, 2019

@jonringer FTR

$ nix-channel --list
home-manager https://github.com/rycee/home-manager/archive/release-19.09.tar.gz
nixpkgs https://nixos.org/channels/nixpkgs-19.09-darwin

Nevertheless, I guess that this PR might be closed as I now learned that I should be able to configure the plugin via overlays (which I am still trying to implement)

@jonringer
Copy link
Contributor

interesting, do darwin installations normally default to the darwin variants? (did you switch it to the channel, or was that selected for you?)

@jonringer
Copy link
Contributor

overlays are usually used when you want to extend/change packages that are likely only to apply to you. adding a vimplugin like this should probably be upstreamed here

@jonringer
Copy link
Contributor

or since you're sending in PRs, do what most of us do and just switch your channel to unstable and then you get your merged PRs through channels ~4hrs later

@Enteee
Copy link
Contributor

Enteee commented Feb 25, 2020

Nevertheless, I guess that this PR might be closed as I now learned that I should be able to configure the plugin via overlays (which I am still trying to implement)

@gotcha could you then please go ahead and close this pull request. Thank you.

@jonringer
Copy link
Contributor

generally we do not backport new packages to a release channel.

Closing

@jonringer jonringer closed this Feb 25, 2020
@gotcha
Copy link
Contributor Author

gotcha commented Feb 28, 2020

@jonringer Thanks for closing
@Enteee You are right, I should have closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants