New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.09] vimPlugins.vimelette: init at 2019-05-02 #73273
Conversation
I think you meant to do this against master.... not nixpkgs-19.09-darwin |
@jonringer I already did it against master and it got merged. Then I wondered how to get from master to nixpkgs-19.09-darwin (See https://discourse.nixos.org/t/nixpkgs-flow-from-master-to-channel/4727). |
do you mind doing a
and posting the output? |
cc @NixOS/darwin-maintainers @NixOS/channel-updaters what's the policy on the darwin variant channels? |
I'm not sure what the nixpkgs-19.09-darwin branch is but it has nothing to do with the channel. |
If you want to backport changes to a release please use |
Well, it seems I first need to better understand how nixpkgs branches get turned into channels. |
@gotcha To be honest, I'm not sure I can point to anything specific. I definitively agree this should be described somewhere. Apparently these channel branches are a recent change for technical reasons, but the fact that they exist makes this even more important now to avoid confusion. |
agreed, and I'm not sure who's driving the darwin channels, but I would like to know their intent with using the darwin variant channels. Only benefit i could see is that it would clear out a lot of non-darwin noise when looking through hydra jobsets, but I think that should be a feature on hydra to sort by targeted architecture |
Either way, the vim-plugins update should not go to the stable channel. It might break things. I'm fine with backporting new packages (i.e. just the |
@gotcha IIRC, you already landed a PR in master, do you mind running:
this PR might not even be necessary |
@jonringer FTR
Nevertheless, I guess that this PR might be closed as I now learned that I should be able to configure the plugin via |
interesting, do darwin installations normally default to the darwin variants? (did you switch it to the channel, or was that selected for you?) |
overlays are usually used when you want to extend/change packages that are likely only to apply to you. adding a vimplugin like this should probably be upstreamed here |
or since you're sending in PRs, do what most of us do and just switch your channel to unstable and then you get your merged PRs through channels ~4hrs later |
@gotcha could you then please go ahead and close this pull request. Thank you. |
generally we do not backport new packages to a release channel. Closing |
@jonringer Thanks for closing |
Added vim plugin vimelette