Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] chromium: 78.0.3904.87 -> 78.0.3904.97 #73286

Merged
merged 1 commit into from Nov 13, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Nov 12, 2019

Motivation for this change

Backport #73284

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested stable: YouTube, gmail, Twitter, audio output, widevine are OK

Notify maintainers

cc @bendlas

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the cherry-pick reference. Currently it points to a PR, but it should point to the commit in master.

@ivan ivan force-pushed the chromium-78.0.3904.97-for-19.09 branch from 626ce73 to 4b2f549 Compare November 13, 2019 07:40
@ivan
Copy link
Member Author

ivan commented Nov 13, 2019

Thanks, fixed the commit message

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
browser launches fine

[12 built, 369 copied (2360.8 MiB), 480.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73286
4 package were build:
chromium google-chrome google-chrome-beta google-chrome-dev

@bjornfor bjornfor merged commit 0be5e24 into NixOS:release-19.09 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants