Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql80: add missing version #68322

Closed
wants to merge 1 commit into from
Closed

mysql80: add missing version #68322

wants to merge 1 commit into from

Conversation

shyim
Copy link
Member

@shyim shyim commented Sep 8, 2019

Motivation for this change

This package is currently unusable using services.mysql, cause it requires a version.
https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/databases/mysql.nix#L19

Error Message currently:
error: attribute 'version' missing, at /nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/databases/mysql.nix:19:38

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @orivej

@c0bw3b c0bw3b closed this in e7f7b47 Nov 28, 2019
c0bw3b added a commit that referenced this pull request Nov 29, 2019
version is needed by the mysql service module
Close #68322

(cherry picked from commit e7f7b47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant