Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: use gcc7 for darwin #68324

Merged
merged 1 commit into from Sep 8, 2019
Merged

gcc: use gcc7 for darwin #68324

merged 1 commit into from Sep 8, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Sep 8, 2019

This was present in the gcc-8 branch but got removed in the merge.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
gcc: use gcc7 for darwin
53e01be 
This was present in the gcc-8 branch but got removed in the merge.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 8, 2019
@FRidh
Copy link
Member Author

FRidh commented Sep 8, 2019

just want ofborg to check whether this fixes the evaluation

@FRidh FRidh mentioned this pull request Sep 8, 2019
Merged
10 tasks
@FRidh FRidh merged commit 5c2c505 into NixOS:staging-next Sep 8, 2019
@FRidh FRidh deleted the gcc8 branch October 14, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh