New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
np2kai: init at 0.86rev22 #68328
np2kai: init at 0.86rev22 #68328
Conversation
After #71108 gets merged, I'll rebase and add the libretro port to the list of available cores. Never used Retroarch before, but the emulator seems to run as expected afaict. I'm just missing the system files on my VM, hence it doesn't get far into the startup process in the screenshot. |
5c3a2c1
to
e9db944
Compare
e9db944
to
1ffb321
Compare
Updated to 0.86rev21 and added the NP2kai core to retroarch. |
9630fdf
to
2d33131
Compare
Fixed the merge conflict, reworked some parts of the derivation. |
Updated to 0.86rev22, added some more settings to the derivation, added support for building with SDL1 and formatted the derivation with |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/175 |
This is already lying around for some time, sorry for this. It is a bit hard to follow, guess that is the reason why. My feedback so far:
Edit I see, cmake was just added recently and is not part of rev.22. In this case it might make sense to use the current master version with cmake instead. There haven't been to many other changes either. |
No problem, the derivation has been kinda growing over time sadly.
It has been requested and re-introduced upstream with rev22, I wanted to support it just in case anyone needs it. Feature request in question here.
I'm afraid you're looking at the current master, which hasn't found its way into a tagged release yet. Rev22 still uses all the manual configure & makefile kerfuffle. I'll gladly look into simplifying everything with cmake once a rev23 is released ofc! |
Yeah, I have noticed it right after posting it and I have edited my previous post :) It's also fine to keep it like that until rev23. SDLv1 support makes less sense with nix, since it will never use any system libraries. However supporting it is fine as well, in regard of a more feature complete derivation. Give me some time to test this locally and to try out a few things. |
Thanks a lot for all the extra information, that’s definitely something new to nerd into :) I have tested it locally and everything seems fine. The derivation will for sure get much simpler due cmake with the next version. Thanks for all the work 👍 |
Thanks for the review & merge! 😄 |
Motivation for this change
Adding Neko Project 2 kai: A feature-rich, cross-platform PC-98 Series emulator.
Includes 2 versions:
I assume the non-Linux SDL versions compile fine, I can only test the Linux one.
I'm not sure on the
stdenv.hostPlatform.isXXX
stuff, or how strict I should define the platform.Tested with proper BIOS files + a hard drive image, appears to run fine.
The repo (as well as libretro fork) includes a libretro port of the emulator, how would I go about to add that?
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)