Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs help] mindustry-bin: init at 5.0 v99 #72198

Closed
wants to merge 1 commit into from

Conversation

wamserma
Copy link
Member

Note: Game launches but sound does not work yet (some OpenAL issue).

Motivation for this change

#72001

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@wamserma
Copy link
Member Author

The jar includes some libraries in binary form, so this requires an extra step to extract the libs from the jar, path them and repack the jar.
Building from source is complicated due to the use of the gradle warpper.

@wamserma wamserma changed the title [RFC] mindustry-bin: init at 5.0 v99 [needs help] mindustry-bin: init at 5.0 v99 Oct 29, 2019
@deliciouslytyped
Copy link
Contributor

deliciouslytyped commented Oct 31, 2019

Oh no, JAR packaging strikes again....
I played this on my phone from fdroid, it's certainly worth packaging.

I wonder how crazy it would be to just depend on steam-run... way oversized closure, but it would run :D

The other side of the horse is in fact that we would ideally want a build from source.
@wamserma have you looked a #17342 (comment) ?
I don't know how much it will help, but it might.

@wamserma
Copy link
Member Author

steam-run would certainly be a way to go as Mindustry is also distributed on Steam, but building from source would be better.

I wasn't aware of #17342 (comment) and will give it a try.

@ghost
Copy link

ghost commented Nov 1, 2019

#72306

@wamserma
Copy link
Member Author

wamserma commented Nov 3, 2019

Closed in favour of #72306.

@wamserma wamserma closed this Nov 3, 2019
@wamserma wamserma deleted the add-mindustry branch April 18, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants