Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptopp: 5.6.5 -> 8.2.0 #72199

Merged
merged 3 commits into from Oct 30, 2019
Merged

cryptopp: 5.6.5 -> 8.2.0 #72199

merged 3 commits into from Oct 30, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 28, 2019 •
edited

Motivation for this change

Poor thing was unmaintained and ignored by nixpkgs-update bot because of its convoluted version declaration.
I've added myself as maintainer and made version a simple var.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-review
    --> I've built many reverse-deps but not scylladb and ceph yet
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Closure size
$ nix path-info -Ssh
/nix/store/wfny8i467jn129h14q6s5dzidpkk9aah-crypto++-5.6.5        12.1M   44.4M
/nix/store/y2gf42wcj64qz92pak53m9c8v9jbcndh-crypto++-8.2.0         8.3M   40.6M

@c0bw3b c0bw3b changed the title Pkg/cryptopp cryptopp: 5.6.5 -> 8.2.0 Oct 28, 2019
@ofborg ofborg bot requested a review from Phreedom October 28, 2019 22:01
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 28, 2019

Ok I'll need to redo the GNUmakefile patch for Darwin

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 29, 2019

I've updated closure size informations above, because static lib sneaked in before.
Now that we install only shared lib + headers and no static lib and no test program/datas the closure size is actually lower than v5.6.5

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 29, 2019

@GrahamcOfBorg build cryptopp python27Packages.pycryptopp amule

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 30, 2019

@GrahamcOfBorg build cryptopp python27Packages.pycryptopp amule

jonringer
jonringer approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (1 broken on master)
diff LGTM
commits LGTM
amule seems to work

[22 built (1 failed), 173 copied (1126.5 MiB), 200.1 MiB DL]
error: build of '/nix/store/8a7irrsqyrf3br506w3x284gi0grx1zc-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72199
3 package are marked as broken and were skipped:
cpp_ethereum ring-daemon tahoe-lafs

1 package failed to build:
ethminer

11 package were build:
amule amuleDaemon amuleGui cryfs cryptopp ethash megasync openxray plasma-vault python27Packages.pycryptopp trv

@jonringer jonringer merged commit ebd7466 into NixOS:master Oct 30, 2019
@c0bw3b c0bw3b deleted the pkg/cryptopp branch October 30, 2019 15:51
This was referenced Nov 19, 2019
Closed
Merged
Lassulus pushed a commit that referenced this pull request Nov 24, 2019
@Lassulus
openxray: make it work again after #72199
c67d3f1
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 15, 2020
@dtzWill
openxray: make it work again after NixOS#72199
5bd5693 
(cherry picked from commit c67d3f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @jonringer