Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NixOS/auto-upgrade: add gzip to service path #72197

Merged
merged 1 commit into from Oct 29, 2019
Merged

NixOS/auto-upgrade: add gzip to service path #72197

merged 1 commit into from Oct 29, 2019

Conversation

benley
Copy link
Member

@benley benley commented Oct 28, 2019

Motivation for this change

Backport of #67587 to nixos-19.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Hmm, I'd think if they used fetchGit the service would need to git as well.

@worldofpeace worldofpeace merged commit 63cdd9b into NixOS:release-19.09 Oct 29, 2019
@benley benley deleted the benley/nixos-auto-upgrade-gzip branch October 29, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roosemberth roosemberth roosemberth approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benley @worldofpeace @roosemberth @jollheef