onefetch: init at 1.7.0 #72254
Closed
onefetch: init at 1.7.0 #72254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmahut
reviewed
Oct 29, 2019
| @@ -3484,6 +3484,16 @@ | |||
| github = "klntsky"; | |||
| githubId = 18447310; | |||
| }; | |||
| kloenk = { | |||
There was a problem hiding this comment.
Do you mind creating a separate commit for adding an user?
mmahut
reviewed
Oct 29, 2019
| , makeRustPlatform | ||
| , fetchFromGitHub | ||
| , lib | ||
| , ... |
mmahut
reviewed
Oct 29, 2019
|
|
||
| meta = with lib; { | ||
| homepage = https://github.com/o2sh/onefetch; | ||
| description = ''Displays information about your Git project directly on your terminal''; |
There was a problem hiding this comment.
Please don't use '' if no multi line.
mmahut
reviewed
Oct 29, 2019
| CARGO_HOME = "$(mktemp -d cargo-home.XXX)"; | ||
|
|
||
| meta = with lib; { | ||
| homepage = https://github.com/o2sh/onefetch; |
mmahut
reviewed
Oct 29, 2019
| }; | ||
| cargoSha256 = "0cpfjxn6nqsrnmgvjzr17n6xbbyfl9c91d5kbrmxb6jyig98k6aq"; | ||
| buildInputs = [ ]; | ||
| CARGO_HOME = "$(mktemp -d cargo-home.XXX)"; |
There was a problem hiding this comment.
Isn't this created by fetchCargo?
mmahut
reviewed
Oct 29, 2019
| sha256 = "1p16mg4ak9ppx3y11l3r4y6356drwhnmrlxsaqx01n53ii5ij9kg"; | ||
| }; | ||
| cargoSha256 = "0cpfjxn6nqsrnmgvjzr17n6xbbyfl9c91d5kbrmxb6jyig98k6aq"; | ||
| buildInputs = [ ]; |
There was a problem hiding this comment.
What is the reason to have an empty buldInputs?
jonringer
reviewed
Oct 30, 2019
| , makeRustPlatform | ||
| , fetchFromGitHub | ||
| , lib | ||
| , ... |
There was a problem hiding this comment.
not needed
Suggested change
| , ... |
|
I hade not so much time, because of school, so I will close this PR in favor of #74191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds onefetch for git repos analysis
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)