Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pango 1.43.0: Fixing wrong sha from #71687 #72253

Closed
wants to merge 1 commit into from
Closed

pango 1.43.0: Fixing wrong sha from #71687 #72253

wants to merge 1 commit into from

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

A faulty hash has snuck in in #71687 and we forgot to run ofborg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c @eadwu

@grahamc
Copy link
Member

grahamc commented Oct 29, 2019

@GrahamcOfBorg build pango

@d-goldin d-goldin force-pushed the backport_cve_2019_1010238_fixhash branch from 7f801f0 to ee13128 Compare October 29, 2019 14:08
@d-goldin d-goldin changed the title pango 1.4.3: Fixing wrong sha from #71687 pango 1.43.0: Fixing wrong sha from #71687 Oct 29, 2019
@d-goldin
Copy link
Contributor Author

force-push was fixing typo in commit msg from 1.4.3 to 1.43.0.

@globin
Copy link
Member

globin commented Oct 29, 2019

Fixed in #72251, thanks anyway! :)

@globin globin closed this Oct 29, 2019
@d-goldin
Copy link
Contributor Author

@globin: Awesome, thanks. Could you please make sure to backport those two fixes to 19.09?

@d-goldin d-goldin deleted the backport_cve_2019_1010238_fixhash branch October 29, 2019 14:12
@WilliButz
Copy link
Member

backported in 9b1ecb4 and 549132c

@d-goldin d-goldin mentioned this pull request Oct 29, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-goldin @grahamc @globin @WilliButz