Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-cmake-mode: do not run configure #72210

Merged
merged 1 commit into from
Nov 1, 2019
Merged

emacs-cmake-mode: do not run configure #72210

merged 1 commit into from
Nov 1, 2019
+4 −13

Conversation

urkud
Copy link
Contributor

@urkud urkud commented Oct 29, 2019

Before this patch, the stable version did not run configure, and the
unstable version added openssl and pkgconfig to
dependencies.

Also, dontConfigure = true seems more readable than configureScript = "true".

Motivation for this change

Save compile time, reduce compile time dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • NO BINARIES Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@urkud
emacs-cmake-mode: do not run configure

Verified

This commit was signed with the committer’s verified signature.
boesing Maximilian Bösing
GPG key ID: 9A8988C93CEC81A3
Verified
Learn about vigilant mode
0681bce 
Before this patch, the stable version did not run configure, and the
unstable version added `openssl` and `pkgconfig` to
dependencies.

Also, `dontConfigure = true` seems more readable than `configureScript
= "true"`.
@urkud urkud requested a review from adisbladis as a code owner October 29, 2019 02:12
@ofborg ofborg bot added 6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2019
@adisbladis adisbladis merged commit 8930e0c into NixOS:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis

Assignees
No one assigned
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @adisbladis