pythonPackages.html2text: Downgrade for old Python versions #72211
Conversation
|
@GrahamcOfBorg build python27Packages.html2text |
There was a problem hiding this comment.
generally this done at the python-modules level, for examples:
scikitlearn = let
args = { inherit (pkgs) gfortran glibcLocales; };
in
if isPy3k then callPackage ../development/python-modules/scikitlearn args
else callPackage ../development/python-modules/scikitlearn/0.20.nix args;
EDIT: just make a new expression, name it '2018.nix' and then do a calling convention like the one above
|
That makes a lot more sense! I just updated it. The derivations didn't seem to have changed at all. |
There was a problem hiding this comment.
nix-review passes on NixOS (1 broken on master)
diff LGTM
[3 built (1 failed), 58 copied (243.7 MiB), 86.0 MiB DL]
error: build of '/nix/store/452rb2a8rnnrhi5l02kljwaws2xmyqx0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72211
1 package failed to build:
python27Packages.weboob
4 package were build:
calibre python27Packages.geeknote python27Packages.html2text trytond
|
can you squash it into one commit, and name it |
|
the more proper solution would be to bump calibre to python3, but this will work for now |
|
I don't know if calibre is fully ready on the upstream side, unfortunately. |
|
I just checked, it's not. But python is EOL in 8 weeks... so they don't have much time |
I was unable tp build calibre at the current git master as it relies on pytthon27Packages.html2text. Python 2.7 support was removed in the latest version. This PR downgrades html2text when using an unsupported Python version. This PR does not fix building python37Packages.html2text and python38Packages.html2text, which were broken at master due to what seems to be a problem in buildPythonPackage.
artemist
force-pushed
the
html2text-fix
branch
from
40866d4
to
4ce0043
Compare
|
@GrahamcOfBorg build pythonPackages.html2text python3Packages.html2text |
|
looks like the python37 version is broken on master, ill fix in a different PR |
Motivation for this change
I was unable tp build calibre at the current git master as it relies on
pytthon27Packages.html2text. Python 2.7 support was removed in the latest version.Things done
This PR downgrades html2text when using an unsupported Python version.
This PR does not fix building
python37Packages.html2textandpython38Packages.html2text, which were broken at master due to what seems to be a problem in buildPythonPackage.sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
None are listed in the package.