Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xapian: 1.4.12 -> 1.4.13 #72118

Merged
merged 1 commit into from Oct 28, 2019
Merged

xapian: 1.4.12 -> 1.4.13 #72118

merged 1 commit into from Oct 28, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 27, 2019

Motivation for this change

Supersedes #71939 simply including an updated darwin patch. And rebased for good measure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

update darwin patch
@jonringer
Copy link
Contributor

@GrahamcOfBorg build xapian

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables still seem to work

[71 built (1 failed), 171 copied (298.3 MiB), 69.3 MiB DL]
error: build of '/nix/store/gvxg2ps06c3507sd729ph114dppqx9av-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72118
1 package are marked as broken and were skipped:
kiwix

67 package were build:
afew akregator alot appstream appstream-qt astroid denemo discover evince glom gmailieer gnome3.gnome-books gnome3.gnome-documents gnome3.sushi haskellPackages.notmuch kaddressbook kdeApplications.akonadi-import-wizard kdeApplications.akonadi-search kdeApplications.akonadiconsole kdeApplications.calendarsupport kdeApplications.eventviews kdeApplications.incidenceeditor kdeApplications.kalarm kdeApplications.kdepim-addons kdeApplications.kdepim-apps-libs kdeApplications.kdepim-runtime khelpcenter kmail kdeApplications.kmail-account-wizard kdeApplications.knotes kontact korganizer kdeApplications.libgravatar kdeApplications.libkdepim kdeApplications.libksieve kdeApplications.mailcommon kdeApplications.mailimporter kdeApplications.mbox-importer kdeApplications.messagelib kdeApplications.pim-data-exporter kdeApplications.pim-sieve-editor kdeApplications.pimcommon meteo mu muchsync neomutt notmuch notmuch-addrlookup pantheon.elementary-calculator pantheon.elementary-camera pantheon.elementary-code pantheon.elementary-greeter pantheon.elementary-photos pantheon.elementary-terminal pantheon.wingpanel-applications-menu pantheon.wingpanel-with-indicators python27Packages.notmuch python27Packages.xapian python37Packages.notmuch python37Packages.xapian python38Packages.alot python38Packages.notmuch python38Packages.xapian recoll xapian xapian-omega zanshin

@marsam marsam merged commit 17b02ef into NixOS:master Oct 28, 2019
@marsam
Copy link
Contributor

marsam commented Oct 28, 2019

Thank you!

@jb55
Copy link
Contributor

jb55 commented Nov 8, 2019

just a heads up that this version is known to crash notmuch: https://notmuchmail.org/pipermail/notmuch/2019/028634.html

@jonringer
Copy link
Contributor

:( why does software have to be so hard :(

@marsam
Copy link
Contributor

marsam commented Nov 8, 2019

interesting, it only happens on specific queries https://trac.xapian.org/ticket/796, and seems to be fixed on master xapian/xapian@f4ed23d1.
@jb55 do you think we need to apply that patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants