Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: 1.18.0.1944 -> 1.18.1.1973 #72196

Merged
merged 1 commit into from Nov 14, 2019
Merged

plex: 1.18.0.1944 -> 1.18.1.1973 #72196

merged 1 commit into from Nov 14, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 28, 2019 •
edited by jonringer

Motivation for this change

Update to latest non plex pass version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @colemickens @Forkk @LnL7 @pjones @thoughtpolice

jonringer
jonringer approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[11 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72196
2 package were build:
plex plexRaw

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 29, 2019
@c0bw3b c0bw3b merged commit ec1a732 into NixOS:master Nov 14, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 14, 2019

r19.09 is at v1.16.5.xxx now. Previous updates have not been backported.
No idea if breakage is to be expected (service module or direct user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemickens colemickens colemickens approved these changes

@jonringer jonringer jonringer approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@pjones pjones Awaiting requested review from pjones

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @c0bw3b @colemickens @jonringer