Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3e639196de91
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 479f75d1e5dd
Choose a head ref
  • 12 commits
  • 11 files changed
  • 10 contributors

Commits on Oct 28, 2019

  1. vte: enable building with musl

    VTE requires a small patch to be able to be built with musl.
    cdepillabout authored and nh2 committed Oct 28, 2019
    Copy the full SHA
    fc265d9 View commit details
  2. symlinkJoin: fix cross

    alyssais committed Oct 28, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    59dbb00 View commit details
  3. perlPackages.Po4a: fix build (#72170)

    Fixes #71296 (Po4a build get stuck in a loop)
    
    Term::ReadKey is an optional dependency. From upstream:
    > This module is used to retrieve the terminal's line width.
    > If it is not present, the line width can be specified with the COLUMN environment variable.
    c0bw3b authored Oct 28, 2019
    Copy the full SHA
    97a5c41 View commit details
  4. cups: enable compiling with musl

    When compiling `cups` with `pkgsMusl`, `cups` can't depend on `systemd`
    because `systemd` is not able to be built with musl.
    cdepillabout authored and nh2 committed Oct 28, 2019
    Copy the full SHA
    664823c View commit details
  5. Merge pull request #71577 from cdepillabout/vte-compiling-with-musl

    vte: enable compiling with musl
    nh2 authored Oct 28, 2019
    Copy the full SHA
    aaddb5f View commit details
  6. Merge pull request #72173 from alyssais/symlinkJoin-cross

    symlinkJoin: fix cross
    Ericson2314 authored Oct 28, 2019
    Copy the full SHA
    1503091 View commit details
  7. liburing: 0.2pre252_a9bb08db -> 0.2

    Signed-off-by: Austin Seipp <aseipp@pobox.com>
    thoughtpolice committed Oct 28, 2019
    Copy the full SHA
    fa4f091 View commit details
  8. Fix link in CONTRIBUTING.md

    davidak authored and FRidh committed Oct 28, 2019
    1
    Copy the full SHA
    bdc3697 View commit details
  9. Copy the full SHA
    3c5f5b1 View commit details
  10. Copy the full SHA
    2d8dc89 View commit details
  11. vector: init at 0.5.0

    Signed-off-by: Austin Seipp <aseipp@pobox.com>
    thoughtpolice committed Oct 28, 2019
    Copy the full SHA
    f86361d View commit details
  12. reuse: 0.5.0 -> 0.5.2

    davidak authored and Jon committed Oct 28, 2019
    Copy the full SHA
    479f75d View commit details
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -51,4 +51,4 @@ For package version upgrades and such a one-line commit message is usually suffi

## Reviewing contributions

See the nixpkgs manual for more details on how to [Review contributions](https://nixos.org/nixpkgs/manual/#sec-reviewing-contributions).
See the nixpkgs manual for more details on how to [Review contributions](https://nixos.org/nixpkgs/manual/#chap-reviewing-contributions).
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
###### Motivation for this change


8 changes: 4 additions & 4 deletions pkgs/development/libraries/liburing/default.nix
Original file line number Diff line number Diff line change
@@ -4,12 +4,12 @@

stdenv.mkDerivation rec {
pname = "liburing";
version = "0.2pre252_${builtins.substring 0 8 src.rev}";
version = "0.2";

src = fetchgit {
url = "http://git.kernel.dk/liburing";
rev = "a9bb08db3f8795eb58239d5dbb888e9c1d424011";
sha256 = "0gv06fcgqhfkqgiqzjb4qzpxh3h595ypw01a0kmhqnmsnvmb624n";
url = "http://git.kernel.dk/${pname}";
rev = "refs/tags/${pname}-${version}";
sha256 = "0dxq7qjrwndgavrrc6y2wg54ia3y5wkmcyhpdk4l5pvh7hw6kpdz";
};

separateDebugInfo = true;
13 changes: 13 additions & 0 deletions pkgs/development/libraries/vte/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{ stdenv
, lib
, fetchurl
, fetchpatch
, gettext
, pkgconfig
, meson
@@ -58,6 +60,17 @@ stdenv.mkDerivation rec {
pango
];

patches =
# VTE needs a small patch to work with musl:
# https://gitlab.gnome.org/GNOME/vte/issues/72
lib.optional
stdenv.hostPlatform.isMusl
(fetchpatch {
name = "0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch";
url = "https://gitlab.gnome.org/GNOME/vte/uploads/c334f767f5d605e0f30ecaa2a0e4d226/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch";
sha256 = "1ii9db9i5l3fy2alxz7bjfsgjs3lappnlx339dvxbi2141zknf5r";
});

postPatch = ''
patchShebangs perf/*
patchShebangs src/box_drawing_generate.sh
3 changes: 2 additions & 1 deletion pkgs/development/perl-modules/Po4a/default.nix
Original file line number Diff line number Diff line change
@@ -9,7 +9,8 @@ buildPerlPackage rec {
sha256 = "1qss4q5df3nsydsbggb7gg50bn0kdxq5wn8riqm9zwkiq6a4bifg";
};
nativeBuildInputs = [ docbook_xsl docbook_xsl_ns ModuleBuild ];
propagatedBuildInputs = [ TextWrapI18N LocaleGettext TermReadKey SGMLSpm UnicodeLineBreak PodParser YAMLTiny ];
propagatedBuildInputs = [ TextWrapI18N LocaleGettext SGMLSpm UnicodeLineBreak PodParser YAMLTiny ];
# TODO: TermReadKey was temporarily removed from propagatedBuildInputs to unfreeze the build
buildInputs = [ gettext libxslt glibcLocales docbook_xml_dtd_412 docbook_sgml_dtd_41 texlive.combined.scheme-basic opensp ];
LC_ALL = "en_US.UTF-8";
SGML_CATALOG_FILES = "${docbook_xml_dtd_412}/xml/dtd/docbook/catalog.xml";
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/acoustics/default.nix
Original file line number Diff line number Diff line change
@@ -3,14 +3,14 @@

buildPythonPackage rec {
pname = "acoustics";
version = "0.2.1";
version = "0.2.2";

checkInputs = [ pytest ];
propagatedBuildInputs = [ numpy scipy matplotlib pandas tabulate ];

src = fetchPypi {
inherit pname version;
sha256 = "d7cec62d3e7a7eb26026f2aacc726fb1dd0b044574cbdee83da654b847543c20";
sha256 = "00981908c7cf54be58c0bfe902d7743225554ecf3432b30723e9300d9f3a0b0e";
};

checkPhase = ''
29 changes: 25 additions & 4 deletions pkgs/misc/cups/default.nix
Original file line number Diff line number Diff line change
@@ -1,9 +1,27 @@
{ stdenv, fetchurl, pkgconfig, removeReferencesTo
, zlib, libjpeg, libpng, libtiff, pam, dbus, systemd, acl, gmp, darwin
, libusb ? null, gnutls ? null, avahi ? null, libpaper ? null
{ stdenv
, fetchurl
, pkgconfig
, removeReferencesTo
, zlib
, libjpeg
, libpng
, libtiff
, pam
, dbus
, enableSystemd ? stdenv.isLinux && !stdenv.hostPlatform.isMusl
, systemd ? null
, acl
, gmp
, darwin
, libusb ? null
, gnutls ? null
, avahi ? null
, libpaper ? null
, coreutils
}:

assert enableSystemd -> systemd != null;

### IMPORTANT: before updating cups, make sure the nixos/tests/printing.nix test
### works at least for your platform.

@@ -33,7 +51,10 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [ pkgconfig removeReferencesTo ];

buildInputs = [ zlib libjpeg libpng libtiff libusb gnutls libpaper ]
++ optionals stdenv.isLinux [ avahi pam dbus systemd acl ]
++ optionals stdenv.isLinux [ avahi pam dbus ]
++ optional enableSystemd systemd
# Separate from above only to not modify order, to avoid mass rebuilds; merge this with the above at next big change.
++ optionals stdenv.isLinux [ acl ]
++ optionals stdenv.isDarwin (with darwin; [
configd apple_sdk.frameworks.ApplicationServices
]);
41 changes: 41 additions & 0 deletions pkgs/tools/misc/vector/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
{ stdenv, lib, fetchFromGitHub, rustPlatform
, openssl, pkgconfig, protobuf
, Security, libiconv

, features ?
(if stdenv.isAarch64
then [ "jemallocator" ]
else [ "leveldb" "jemallocator" ])
}:

rustPlatform.buildRustPackage rec {
pname = "vector";
version = "0.5.0";

src = fetchFromGitHub {
owner = "timberio";
repo = pname;
rev = "refs/tags/v${version}";
sha256 = "0niyxlvphn3awrpfh1hbqy767cckgjzyjrkqjxj844czxhh1hhff";
};

cargoSha256 = "0bdgan891hrah54g6aaysqizkxrfsbidnxihai0i7h7knzq9gsk5";
buildInputs = [ openssl pkgconfig protobuf ]
++ stdenv.lib.optional stdenv.isDarwin [ Security libiconv ];

# needed for internal protobuf c wrapper library
PROTOC="${protobuf}/bin/protoc";
PROTOC_INCLUDE="${protobuf}/include";

# rdkafka fails to build, for some reason...
cargoBuildFlags = [ "--no-default-features" "--features" "${lib.concatStringsSep "," features}" ];
checkPhase = ":"; # skip tests, too -- they don't respect the rdkafka flag...

meta = with stdenv.lib; {
description = "A high-performance logs, metrics, and events router";
homepage = "https://github.com/timberio/vector";
license = with licenses; [ asl20 ];
maintainers = with maintainers; [ thoughtpolice ];
platforms = platforms.all;
};
}
6 changes: 3 additions & 3 deletions pkgs/tools/package-management/reuse/default.nix
Original file line number Diff line number Diff line change
@@ -4,13 +4,13 @@ with python3Packages;

buildPythonApplication rec {
pname = "reuse";
version = "0.5.0";
version = "0.5.2";

src = fetchFromGitHub {
owner = "fsfe";
repo = "reuse-tool";
rev = "v${version}";
sha256 = "1w17g6jvs715rjc93nnnqnfdphijq4ymj9jjkr3ccc286ywvn3ih";
sha256 = "17qvsa2qnm767yv7x0v626np0kiyqpb0al7sjqmccarq2wnw8w90";
};

propagatedBuildInputs = [
@@ -28,7 +28,7 @@ buildPythonApplication rec {
meta = with lib; {
description = "A tool for compliance with the REUSE Initiative recommendations";
homepage = "https://github.com/fsfe/reuse-tool";
license = with licenses; [ asl20 cc-by-sa-40 cc0 gpl3 ];
license = with licenses; [ asl20 cc-by-sa-40 cc0 gpl3Plus ];
maintainers = [ maintainers.FlorianFranzen ];
};
}
4 changes: 4 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
@@ -24201,6 +24201,10 @@ in
inherit (darwin.apple_sdk.frameworks) Security;
};

vector = callPackage ../tools/misc/vector {
inherit (darwin.apple_sdk.frameworks) Security;
};

epkowa = callPackage ../misc/drivers/epkowa { };

utsushi = callPackage ../misc/drivers/utsushi { };
2 changes: 1 addition & 1 deletion pkgs/top-level/stage.nix
Original file line number Diff line number Diff line change
@@ -71,7 +71,7 @@ let

trivialBuilders = self: super:
import ../build-support/trivial-builders.nix {
inherit lib; inherit (self) stdenv stdenvNoCC; inherit (self.xorg) lndir;
inherit lib; inherit (self) stdenv stdenvNoCC; inherit (self.pkgsBuildHost.xorg) lndir;
inherit (self) runtimeShell;
};