Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nexus: 3.18.1-01 -> 3.19.1-01 #72193

Merged
merged 1 commit into from Nov 1, 2019
Merged

nexus: 3.18.1-01 -> 3.19.1-01 #72193

merged 1 commit into from Nov 1, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 28, 2019 •
edited

Motivation for this change

Relevant release notes:

Also added preferLocalBuild = true; to prevent builds on remote
machines as this only means elevated network access (tarball is fetched
locally and uploaded to the builder) and the build is fairly trivial.

To fix the startup I had to add the JVM parameter java.endorsed.dirs
to ensure that all libraries are loaded properly[1].

[1] https://issues.sonatype.org/browse/NEXUS-21603

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
nexus: 3.18.1-01 -> 3.19.1-01
df77270 
Relevant release notes:

* https://help.sonatype.com/repomanager3/release-notes/2019-release-notes#id-2019ReleaseNotes-RepositoryManager3.19.1
* https://help.sonatype.com/repomanager3/release-notes/2019-release-notes#id-2019ReleaseNotes-RepositoryManager3.19.0

Also added `preferLocalBuild = true;` to prevent builds on remote
machines as this only means elevated network access (tarball is fetched
locally and uploaded to the builder) and the build is fairly trivial.

To fix the startup I had to add the JVM parameter `java.endorsed.dirs`
to ensure that all libraries are loaded properly[1].

[1] https://issues.sonatype.org/browse/NEXUS-21603
jonringer
jonringer approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
no idea how to test it

[3 built, 1 copied (96.5 MiB), 25.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72193
1 package were build:
nexus

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2019

nixpkgs does 😼

@GrahamcOfBorg test nexus

aespinosa
aespinosa approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@aespinosa aespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ironpinguin
ironpinguin approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@ironpinguin ironpinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

as expected nexus works like before

@c0bw3b c0bw3b merged commit e69fd93 into NixOS:master Nov 1, 2019
@Ma27 Ma27 deleted the bump-nexus branch November 1, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aespinosa aespinosa aespinosa approved these changes

@ironpinguin ironpinguin ironpinguin approved these changes

@zaninime zaninime zaninime approved these changes

@jonringer jonringer jonringer approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @c0bw3b @aespinosa @ironpinguin @zaninime @jonringer