nixos/zfs: add autoReplication to module list #72140
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I had added the zfs.autoReplication module settings a while back but hadn't followed up until recently. It looks like I missed adding this module to the module-list and it wasn't getting pulled in as something consumable.
I'd love any guidance on properly vetting this as well as confirmation that this is all that I missed in my earlier pull request (#65407).
Also, do I need to create a second pull request to merge this into 19.09? Is that kind of fix frowned upon?
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @