Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnutls-kdh: fix build #72138

Closed
wants to merge 2 commits into from
Closed

gnutls-kdh: fix build #72138

wants to merge 2 commits into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

closes #72123

gnutls-kdh doesn't build with nettle 3.5.1, this pretty much reverts the bump for gnutls-kdh only

also fixes lutris build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor Author

also made an upstream issue arpa2/gnutls-kdh#2 but the last commit was 3 years ago

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 28, 2019 •
edited

Indeed, I'm not sure it's worth maintaining an old nettle if upstream is never going to update.

About lutris : the Dolphin emulator already depends on mbedtls and I don't see why it would need this old gnutls fork. @abbradar and @Chiiruno may provide some insight here

@jonringer
Copy link
Contributor Author

I'm almost more than okay removing gnutls-kdh from lutris

@jonringer
Copy link
Contributor Author

closing in favor of #72280

@jonringer jonringer closed this Oct 30, 2019
@jonringer jonringer deleted the fix-gnutls-kdh branch October 30, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnutls-kdh-1.0.drv doesn't build
2 participants
@jonringer @c0bw3b