Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.html2text: fix build #72213

Merged
merged 1 commit into from Oct 29, 2019
Merged

python3Packages.html2text: fix build #72213

merged 1 commit into from Oct 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2019 •
edited

Motivation for this change

noticed the python3 build was broken while reviewing #72211

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[4 built, 2 copied (0.4 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72213
4 package were build:
fanficfare python37Packages.html2text python38Packages.html2text rss2email

@jonringer jonringer requested a review from FRidh as a code owner October 29, 2019 05:31
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build fanficfare python37Packages.html2text python38Packages.html2text rss2email

@jonringer
Copy link
Contributor Author

seeing as how the build is broken on master, I'm merging.

Built on linux and darwin

@jonringer jonringer merged commit 753ab3c into NixOS:master Oct 29, 2019
@jonringer jonringer deleted the fix-html2text branch October 29, 2019 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer