Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrayfire: update #72142

Merged
merged 1 commit into from Nov 6, 2019
Merged

arrayfire: update #72142

merged 1 commit into from Nov 6, 2019

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 28, 2019 •
edited

  • Depend on clfft, clblas, and opencl-clhpp from nixpkgs (do not
    fetch their sources)
  • Add buildDocs flag. When set to true, arrayfire's docs will be
    built using doxygen.
  • Ensure that cudatoolkit is not evaluated on darwin.
  • Move python from buildInputs to nativeBuildInputs.
  • Meta: Shrink description and add longDescription.
  • Meta: homepage formatting now adheres to nixpkgs manual.
  • A few minour syntactic-only changes.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@chessai chessai mentioned this pull request Oct 28, 2019
Closed
10 tasks
@chessai chessai mentioned this pull request Nov 6, 2019
Open
@chessai
arrayfire: update
61dda30 
- Depend on `clfft`, `clblas`, and `opencl-clhpp` from nixpkgs (do not
fetch their sources)
- Add `buildDocs` flag. When set to true, arrayfire's docs will be
built using `doxygen`.
- Ensure that `cudatoolkit` is not evaluated on darwin.
- Move `python` from `buildInputs` to `nativeBuildInputs`.
- Meta: Shrink `description` and add `longDescription`.
- Meta: `homepage` formatting now adheres to nixpkgs manual.
- Meta: remove version
- A few minour syntactic-only changes.
@cleverca22 cleverca22 merged commit 5a715fc into NixOS:master Nov 6, 2019
@chessai chessai deleted the arrayfire-update branch November 6, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 cleverca22 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chessai @cleverca22