Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/modules/system/boot: Add support for btrfs auto-resizing at boot #72143

Closed
wants to merge 1 commit into from
Closed

nixos/modules/system/boot: Add support for btrfs auto-resizing at boot #72143

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2019

Motivation for this change

This is an attempt at allowing auto-resize of btrfs file systems at boot, in preparation for #72084.

⚠️ This has not been tested yet, and probably doesn't work as it is right now. It takes a really long time to test this on my machine, probably because I'm doing something wrong or because it invalidates a lot of packages in the cache. If anyone can help me by pointing me in the right direction, I'd be very grateful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

@roosemberth
Copy link
Contributor

@samvv Just throwing an idea here: have you tried rebuilding and testing in a VM? (e.g. NIXOS_CONFIG="$(readlink -f test-cfg.nix)" nixos-rebuild build-vm && ./result/bin/run-*-vm -chardev stdio,mux=on,id=char0,signal=off -mon chardev=char0,mode=readline -serial chardev:char0 -snapshot

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@RaitoBezarius
Copy link
Member

OP do not exist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants