Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-license-detector: init at 3.0.2 #72141

Merged
merged 1 commit into from Feb 13, 2020
Merged

go-license-detector: init at 3.0.2 #72141

merged 1 commit into from Feb 13, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 28, 2019

Motivation for this change

Another utility for detecting licenses under which source files are
licensed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit October 28, 2019 06:38
mmahut
mmahut reviewed Oct 28, 2019
View reviewed changes
pkgs/development/tools/misc/go-license-detector/default.nix Outdated
sha256 = "10dc7ra37bj107f4fvlprph2i0af0ma31d5alwz6h9dm3pdpk7xs";
};

modSha256 = "1qidp8y5k1yi68rgm9m678c5kzqd3hxl8hrk32qvw901wm6daz5s";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
modSha256 = "1qidp8y5k1yi68rgm9m678c5kzqd3hxl8hrk32qvw901wm6daz5s";
modSha256 = "11knn08zsylsyzngahgc7p0b5rmgzdl72nfs6vh6p8jmz28xy71l"; 
hash mismatch in fixed-output derivation '/nix/store/ykm1qyal4cybn5hsqc05xva7h3846r8v-go-license-detector-3.0.1-go-modules':
  wanted: sha256:1qidp8y5k1yi68rgm9m678c5kzqd3hxl8hrk32qvw901wm6daz5s
  got:    sha256:11knn08zsylsyzngahgc7p0b5rmgzdl72nfs6vh6p8jmz28xy71l

@Ekleog
Copy link
Member

Ekleog commented Nov 11, 2019

@dtzWill Any interest in fixing the hash mismatch?

@dtzWill dtzWill force-pushed the feature/go-license-detector-3.0.1 branch from 69cffd3 to 3991c60 Compare February 13, 2020 02:35
@dtzWill dtzWill changed the title go-license-detector: init at 3.0.1 go-license-detector: init at 3.0.2 Feb 13, 2020
@dtzWill
Copy link
Member Author

dtzWill commented Feb 13, 2020

Bump to 3.0.2 (nevermind branch name, teehee), hash should be good sorry about that :).

@dtzWill dtzWill merged commit ed54e4f into NixOS:master Feb 13, 2020
@dtzWill dtzWill deleted the feature/go-license-detector-3.0.1 branch February 13, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Ekleog @mmahut