Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libck: init at 0.7.0 #72144

Merged
merged 1 commit into from Oct 31, 2019
Merged

libck: init at 0.7.0 #72144

merged 1 commit into from Oct 31, 2019

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 28, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Oct 29, 2019

@GrahamcOfBorg build libck

vyp
vyp suggested changes Oct 29, 2019
View reviewed changes
pkgs/development/libraries/libck/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libck/default.nix Outdated Show resolved Hide resolved
@chessai
Copy link
Member Author

chessai commented Oct 29, 2019

suggested changes applied. rebased.

vyp
vyp approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@vyp vyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chessai
Copy link
Member Author

chessai commented Oct 29, 2019

@vyp thanks for reviewing!

@chessai
Copy link
Member Author

chessai commented Oct 30, 2019

@vyp could this be merged? Thanks!

@vyp
Copy link
Member

vyp commented Oct 30, 2019

Sorry don't have commit access! 😅 I've asked on irc though.

@chessai
Copy link
Member Author

chessai commented Oct 30, 2019

Oh, thought you did, sorry. Thanks!

@mmahut
Copy link
Member

mmahut commented Oct 31, 2019

@GrahamcOfBorg build libck

@mmahut mmahut merged commit bd2bccc into NixOS:master Oct 31, 2019
@chessai
Copy link
Member Author

chessai commented Oct 31, 2019

@mmahut thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chessai @mmahut @vyp