Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.cherrypy: 18.1.2 -> 18.3.0 and fix tests #72276

Merged
merged 1 commit into from Oct 31, 2019
Merged

python3.pkgs.cherrypy: 18.1.2 -> 18.3.0 and fix tests #72276

merged 1 commit into from Oct 31, 2019

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 29, 2019 •
edited

Motivation for this change

Fixes #72154.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @username1001101

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3.pkgs.cherrypy python38.pkgs.cherrypy python.pkgs.cherrypy

jonringer
jonringer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (1 broken on master)
diff LGTM
commits LGTM
executables seem to work

[17 built (1 failed), 35 copied (51.5 MiB), 12.0 MiB DL]
error: build of '/nix/store/iipkkxm5lq0d35hgbzbn89716ljdq4a3-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72276
1 package are marked as broken and were skipped:
bareos

1 package failed to build:
flexget

15 package were build:
ceph ceph-client libceph mnemosyne python37Packages.bugseverywhere python37Packages.cherrypy python37Packages.pyalgotrade python37Packages.ws4py python37Packages.zerobin python38Packages.bugseverywhere python38Packages.cherrypy python38Packages.pyalgotrade python38Packages.ws4py python38Packages.zerobin sambaFull

@jonringer jonringer merged commit 03ec5e7 into NixOS:master Oct 31, 2019
@ajs124 ajs124 deleted the fix/cherrypy branch October 31, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git Master: CherryPy fails to build
2 participants
@ajs124 @jonringer