Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.CryptECB: init at 2.21 #72214

Merged
merged 1 commit into from Nov 15, 2019

Conversation

tekeri
Copy link
Contributor

@tekeri tekeri commented Oct 29, 2019

Motivation for this change

Add a missing perl package.

This is my first contribution to the open source project. Feel free to teach me anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@tekeri
Copy link
Contributor Author

tekeri commented Oct 29, 2019

EDIT: Changed maintainer @??? to @FRidh

@tekeri
Copy link
Contributor Author

tekeri commented Nov 11, 2019

cc @c0bw3b
Could you?

@tekeri tekeri changed the title perl5.28.2-Crypt-ECB: init at 2.21 perlPackages-Crypt-ECB: init at 2.21 Nov 11, 2019
@tekeri tekeri changed the title perlPackages-Crypt-ECB: init at 2.21 perlPackages.Crypt-ECB: init at 2.21 Nov 11, 2019
@tekeri tekeri changed the title perlPackages.Crypt-ECB: init at 2.21 perlPackages.CryptECB: init at 2.21 Nov 11, 2019
@tekeri tekeri force-pushed the feature/add-perl-module-crypt-ecb branch from 297ce92 to 90679df Compare November 11, 2019 12:00
@tekeri
Copy link
Contributor Author

tekeri commented Nov 11, 2019

Fixed name

@tekeri tekeri force-pushed the feature/add-perl-module-crypt-ecb branch from 90679df to cc780aa Compare November 12, 2019 10:48
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Result of nix-review pr 72214 1

2 package were build:
  • perl528Packages.CryptECB
  • perl530Packages.CryptECB

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2019

@GrahamcOfBorg build perl528Packages.CryptECB perl530Packages.CryptECB

@c0bw3b c0bw3b merged commit d6fa540 into NixOS:master Nov 15, 2019
@tekeri tekeri deleted the feature/add-perl-module-crypt-ecb branch November 16, 2019 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants