Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minio: 2019-02-26T19-51-46Z -> 2019-10-12T01-39-57Z #72024

Merged
merged 1 commit into from Oct 28, 2019
Merged

minio: 2019-02-26T19-51-46Z -> 2019-10-12T01-39-57Z #72024

merged 1 commit into from Oct 28, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 26, 2019 •
edited

Motivation for this change

Update to latest version: https://github.com/minio/minio/releases/tag/RELEASE.2019-10-12T01-39-57Z

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eelco

@ofborg ofborg bot requested review from edolstra and kalbasit October 26, 2019 13:32
@xbreak
Copy link
Contributor

xbreak commented Oct 27, 2019

I tested this manually on CentOS 7.4. It seems to work fine.

@mmahut
Copy link
Member

mmahut commented Oct 27, 2019

@GrahamcOfBorg test minio

@mmahut
Copy link
Member

mmahut commented Oct 27, 2019

@GrahamcOfBorg build minio

@bachp
Copy link
Member Author

bachp commented Oct 27, 2019

@mmahut The test seems to fail because of the python minio package. I don't see a direct relation but after updating the packages and adding the future dependency the test also passes on master now.

/cc @peterromfeldhk as the maintainer of the python minio package

@mmahut
Copy link
Member

mmahut commented Oct 27, 2019

@GrahamcOfBorg test minio

@jonringer
Copy link
Contributor

@ofborg build minio python37Packages.minio python38Packages.minio

jonringer
jonringer approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
python packages look good

[5 built (2 failed), 3 copied (6.0 MiB), 1.3 MiB DL]
error: build of '/nix/store/slhz3s7zzvwblkv1jyhfpfwcy5324564-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72024
1 package failed to build:
python37Packages.rl-coach

3 package were build:
minio python37Packages.minio python38Packages.minio

@mmahut
Copy link
Member

mmahut commented Oct 28, 2019

Can you please rebase this pull request?

@bachp
Copy link
Member Author

bachp commented Oct 28, 2019

@mmahut done

@ofborg ofborg bot removed the 6.topic: python label Oct 28, 2019
@mmahut mmahut merged commit e79bc59 into NixOS:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@kalbasit kalbasit Awaiting requested review from kalbasit

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @xbreak @mmahut @jonringer