Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase-gui: add libappindicator-gtk3 lib to path #72147

Closed
wants to merge 1 commit into from
Closed

keybase-gui: add libappindicator-gtk3 lib to path #72147

wants to merge 1 commit into from
+3 −1

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Oct 28, 2019 •
edited
Loading

Motivation for this change

electron needs libappindicator-gtk3 library so that it can draw indicators in gnome.

Things done

added indicator and verified it worked on my machine. im also interested in backporting this to 19.09

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@mogorman
keybase-gui: add libappindicator-gtk3 lib to path

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
21bbb92
@ofborg ofborg bot requested review from puffnfresh and np October 28, 2019 08:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 28, 2019
@judaew judaew mentioned this pull request Nov 17, 2019
Merged
10 tasks
@ryantm ryantm closed this Nov 17, 2019
@ryantm
Copy link
Member

ryantm commented Nov 17, 2019

Incorporated in #73480

@mogorman mogorman deleted the keybase-gui-indicator branch November 18, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puffnfresh puffnfresh

@np np

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mogorman @ryantm