Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symlinkJoin: fix cross #72173

Merged
merged 1 commit into from Oct 28, 2019
Merged

symlinkJoin: fix cross #72173

merged 1 commit into from Oct 28, 2019

Conversation

alyssais
Copy link
Member

I’m a bit confused by this — I don’t understand how it could have been broken all this time with nobody noticing! But apparently it was…

Ericson2314
Ericson2314 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I have no idea either. xorg, as the premier example of newScope has had an....evolving cross story (it's still not good enough), but not in a way that I'd think would have made this work before.

@Ericson2314 Ericson2314 merged commit 1503091 into NixOS:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @bjornfor @Ericson2314