Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nototools: make compatible with python3, unblock channel #72232

Merged
merged 4 commits into from Oct 29, 2019
Merged

python3Packages.nototools: make compatible with python3, unblock channel #72232

merged 4 commits into from Oct 29, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 29, 2019 •
edited

Motivation for this change

The latest version of the Python package fonttools is no longer Python 2 compatible, breaking nototools and thus certain font generation.

By updating nototools and applying patches it is now (mostly) Python 3 compatible.

Note we could also add an older Python 2 version of fonttools, but longer-term we should get rid of Python 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh mentioned this pull request Oct 29, 2019
Closed
@FRidh FRidh requested a review from jtojnar October 29, 2019 10:26
@FRidh
Copy link
Member Author

FRidh commented Oct 29, 2019

@GrahamcOfBorg build noto-fonts-emoji

@FRidh FRidh added this to Needs review in Python 2 deprecation Oct 29, 2019
@FRidh FRidh merged commit 04be5b8 into NixOS:master Oct 29, 2019
@FRidh FRidh deleted the nototools branch October 29, 2019 12:53
@FRidh FRidh moved this from Needs review to Merged in Python 2 deprecation Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
1.severity: blocker 6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Python 2 deprecation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh