Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.pandoc-emphasize-code: mark as not broken #72200

Merged
merged 1 commit into from Oct 30, 2019
Merged

haskellPackages.pandoc-emphasize-code: mark as not broken #72200

merged 1 commit into from Oct 30, 2019

Conversation

rycee
Copy link
Member

@rycee rycee commented Oct 28, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee rycee mentioned this pull request Oct 28, 2019
Merged
10 tasks
@cdepillabout
Copy link
Member

@peti Just to make sure, when marking Haskell packages as unbroken on 19.09, it is okay to directly modify pkgs/development/haskell-modules/hackage-packages.nix, right?

@rycee rycee force-pushed the unbreak-pandoc-emphasize-code-19.09 branch from f358057 to 86a4c9b Compare October 29, 2019 21:26
@peti
Copy link
Member

peti commented Oct 30, 2019 •
edited

@cdepillabout,

When marking Haskell packages as unbroken on 19.09, it is okay to directly modify pkgs/development/haskell-modules/hackage-packages.nix, right?

Yes, there are no automatic update processes taking place on the release branches, so editing hackage-packages.nix seems fine as long as the changes are also made in the appropriate config files so that a manual re-generation of the file won't lose those changes.

@peti peti merged commit 12f5d47 into NixOS:release-19.09 Oct 30, 2019
@rycee rycee deleted the unbreak-pandoc-emphasize-code-19.09 branch October 30, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rycee @cdepillabout @peti