Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: clarify things done re: sandboxing #72201

Merged
merged 1 commit into from Oct 30, 2019
Merged

.github: clarify things done re: sandboxing #72201

merged 1 commit into from Oct 30, 2019

Conversation

azuzunaga
Copy link
Contributor

Motivation for this change

Todo checklist should mention that sandboxing on macOS does not work, per #58147 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

please squash into one commit

git reset HEAD~2
git add .github
git commit --amend --no-edit
git push <fork> <branch> --force

@azuzunaga
.github: clarify things done re: sandboxing
5c59da4 
Per NixOS#58147 (comment)
sandboxing is not fully functional on macOS.

.github: specify where sandboxing can be run

Co-Authored-By: Jon <jonringer@users.noreply.github.com>

.github: remove macOS note
@Mic92 Mic92 merged commit 7051982 into NixOS:master Oct 30, 2019
@azuzunaga azuzunaga deleted the update-readme-macos-sandbox branch November 28, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@roosemberth roosemberth roosemberth approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@azuzunaga @jonringer @roosemberth @Mic92