Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.pandoc-emphasize-code: mark unbroken #72119

Merged
merged 1 commit into from Oct 27, 2019
Merged

haskellPackages.pandoc-emphasize-code: mark unbroken #72119

merged 1 commit into from Oct 27, 2019

Conversation

rycee
Copy link
Member

@rycee rycee commented Oct 27, 2019 •
edited

Motivation for this change

To unbreak pandoc-emphasize-code. It actually seems to build just fine without any change necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee
haskellPackages.pandoc-emphasize-code: mark unbroken
a0fe797 
It builds fine without any additional change.
cdepillabout
cdepillabout approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rycee Thanks for this PR.

I've confirmed that pandoc-emphasize-code is able to be compiled, so I will go ahead and merge this in.

pandoc-emphasize-code should be marked unbroken the next time the hackage package set is regenerated, which generally happens once a week or so.

@cdepillabout cdepillabout merged commit 10f4ffd into NixOS:haskell-updates Oct 27, 2019
@rycee rycee deleted the unbreak-pandoc-emphasize-code branch October 27, 2019 21:56
@rycee
Copy link
Member Author

rycee commented Oct 27, 2019

Thanks for the quick merge.

@rycee
Copy link
Member Author

rycee commented Oct 27, 2019

Oh, @cdepillabout is it possible to backport this change to 19.09 as well?

@cdepillabout
Copy link
Member

cdepillabout commented Oct 27, 2019 •
edited

@rycee Yes, I believe it is. If you open a PR for the backport to the release-19.09 branch, I will review it.

@peti Just to make sure, when backporting these kinds of changes to 19.09, it is okay to directly modify pkgs/development/haskell-modules/hackage-packages.nix, right?

edit: I moved this question to the actual PR: #72200 (comment)

@rycee
Copy link
Member Author

rycee commented Oct 28, 2019

Thanks @cdepillabout! I've opened #72200 for the 19.09 change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rycee @cdepillabout