log more commands #1197
Merged
log more commands #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have removed the controversial logging and logged an additionnal ssh command. Looking forward to see this merged. |
|
I don't think emitting verbose logging by default is a good idea ? this should at least be done only if --debug is set imo. |
|
sure. Fixed. |
when --debug is set
to help debugging
|
really addressed the comment this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while developing on nixops, I regularly have issues and logging the run command helps a lot in debugging.
I wonder if nixops should have different levels but it would be cool to better log commands.
(I can remove the NIX_SSHOPTS)