Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP support #684

Closed
wants to merge 3 commits into from
Closed

Add LDAP support #684

wants to merge 3 commits into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 28, 2019

This closes #53.

The two main things that need fixing before this is ready are:

  • The config parsing
    • Assuming a separate config file is fine, I could not manage to figure out how to load and apply it conditionally.
    • Assuming these options should be put into HYDRA_CONFIG, I failed at figuring that out as well.
  • The LDAP to hydra group/role mapping
    • Right now, it literally checks if they start with hydra: 1
    • and then strips the first 6 characters from the roles: 2.

Furthermore, this introduces a dependency on Catalyst::Authentication::Store::LDAP, which is not part of nixpkgs right now.

cc @dasJ @edef1c

@gilligan
Copy link
Contributor

gilligan commented May 8, 2020

@ajs124 any chance you might pick this up again?

@ajs124
Copy link
Member Author

ajs124 commented May 9, 2020

Maybe. We still run it in production.

@grahamc
Copy link
Member

grahamc commented Sep 11, 2020

This PR was continued and merged!

@grahamc grahamc closed this Sep 11, 2020
@ajs124 ajs124 deleted the ldap branch September 11, 2020 16:13
@grahamc grahamc mentioned this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LDAP support
4 participants