Introduce NixOPS plugin structure #72266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgs.nixopsCore now contains only the None/AWS/Hetzner backends,
other backends are available through pkgs.nixopsPlugins such as
pkgs.nixopsPlugins.nixops-vbox for VirtualBox.
There is also a convenience pkgs.nixopsWithPlugins which makes it
possible to quickly package a NixOPS with additional backends e.g:
```Nix
let
nixopsGCE = nixopsPlugins.buildNixOpsPlugin rec {
pluginName = "gce";
src = builtins.fetchGit "https://github.com/AmineChikhaoui/nixops-gce";
version = "pre853_aca0173";
propagatedBuildInputs = [ python2Packages.libcloud ];
};
in nixopsWithPlugins {
plugins = with nixopsPlugins;
[ nixops-aws nixops-hetzner nixops-libvirtd nixops-datadog nixops-vbox ]
++ [ nixopsGCE ];
}
```
AmineChikhaoui
changed the title
rbvermaa
approved these changes
Nov 7, 2019
teto
approved these changes
Nov 14, 2019
|
It would be better to follow the same API model as python.withPackages / terraform.withPlugins etc: Terraform has an additionally very useful |
|
Superseded by #83548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkgs.nixopsCore now contains only the None/AWS/Hetzner backends,
other backends are available through pkgs.nixopsPlugins such as
pkgs.nixopsPlugins.nixops-vbox for VirtualBox.
There is also a convenience pkgs.nixopsWithPlugins which makes it
possible to quickly package a NixOPS with additional backends e.g:
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @disassembler @edolstra @rbvermaa