Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/syncthing: simple versioning #72268

Merged
merged 1 commit into from Nov 12, 2019
Merged

nixos/syncthing: simple versioning #72268

merged 1 commit into from Nov 12, 2019

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

versioning was missing as a configuration parameter. I implemented only "simple" because I don't understand most of the other types.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus

@aanderse
Copy link
Member

aanderse commented Nov 1, 2019

If someone were to implement the other types of versioning would they be able to do so in a backwards compatible way with this PR?

@mrVanDalo
Copy link
Contributor Author

@aanderse I guess not. One of the problems I had with understanding the other types for versioning is on how to model the different types as nixos module.

Most simple setup, "keep n versions" and "keep versions for n days". Than it would be something like

versioning = {
  type = enum ["none" "versions" "days"];
  keep = int;
};

But I guess this will instantly clash with the next type of version which is available by syncthing.

add simple versioning. I did not add the other versioning
types because I did not understand most of them.
@mrVanDalo
Copy link
Contributor Author

@aanderse All versioning types are implemented now.

@aanderse
Copy link
Member

aanderse commented Nov 7, 2019

@mrVanDalo seems like a reasonable implementation. Thanks!

@peterhoeg
Copy link
Member

@GrahamcOfBorg build tests.syncthing-init

@Lassulus Lassulus merged commit 69493cc into NixOS:master Nov 12, 2019
@FRidh
Copy link
Member

FRidh commented Nov 13, 2019

I just reverted this in 17b9054 because descriptions were missing for params and type. Should be easy to add.

@mrVanDalo
Copy link
Contributor Author

will add descriptions, on sunday or monday because I will be offline for a while.

@mrVanDalo
Copy link
Contributor Author

See #73405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants