Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bshapr & bsequencer: init at v0.4 #72267

Merged
merged 2 commits into from Oct 31, 2019
Merged

bshapr & bsequencer: init at v0.4 #72267

merged 2 commits into from Oct 31, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This was referenced Oct 30, 2019
Merged
Closed
@marsam
Copy link
Contributor

marsam commented Oct 31, 2019

LGTM, would you mind rebasing onto master?

@magnetophon
Copy link
Member Author

OK, done!

@marsam marsam merged commit f73e006 into NixOS:master Oct 31, 2019
@marsam
Copy link
Contributor

marsam commented Oct 31, 2019

Thank you for your contribution. btw feel free to ping me if any pr gets stuck :)

@magnetophon
Copy link
Member Author

@marsam Thanks for the great offer! :)

@magnetophon magnetophon deleted the sjaehn branch October 31, 2019 01:44
@magnetophon magnetophon mentioned this pull request Nov 15, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @marsam